Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document procedure to generate ELF binaries used in unit tests #30

Open
aljimenezb opened this issue Mar 25, 2020 · 3 comments
Open

Document procedure to generate ELF binaries used in unit tests #30

aljimenezb opened this issue Mar 25, 2020 · 3 comments
Assignees

Comments

@aljimenezb
Copy link
Contributor

As discussed in #29, it is useful to have the instructions for generating the ELF binaries used for unit tests. Currently those instructions appear in the commits that introduce the binaries e.g. 0ce5bfa

Possible approaches are:

  • add a section on the main README
  • create a separate document
  • generate the binaries at build time using Rust inline assembly
@alxiord
Copy link
Member

alxiord commented Mar 26, 2020

How about a build hook that generates them, similar to how the bzimage test payload is obtained? For that, this script is run before the unit tests for bzimage. Can the build steps be packaged in a shell script and similarly included in the build?

LE: there's also a section in the readme on how to build the test binaries.

@andreeaflorescu
Copy link
Member

We could also have this in two steps:

  1. Add a section in a separate doc
  2. Actually generate those binaries at build time

WDYT?

@alxiord
Copy link
Member

alxiord commented Mar 26, 2020

Item 1 is a natural predecessor to 2, 2 could be picked up by any contributor who has the instructions, I like it.

@andreeaflorescu andreeaflorescu self-assigned this Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants