You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think I mentioned all this in the review over in #5 but I'll add it here for posterity :)
Getting rid of the copy-paste here is definitely a good idea! I just think that doing it via traits is the wrong approach. Rather, using a macro to take care of the definitions means that we don't have to copy paste anymore but still keeps these methods declared with the type in the documentation and when people are using autocomplete to find them.
There are a lot of wrapper types that expose internal types, which is unnecessary for most usage scenarios.
Maybe we can extract some traits to hide it like AsPtr?
And we could add a produce macros to generate those implementations
The text was updated successfully, but these errors were encountered: