Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow data as layer input, always require data:<data_key_name> #520

Open
albertz opened this issue May 21, 2021 · 5 comments
Open

Disallow data as layer input, always require data:<data_key_name> #520

albertz opened this issue May 21, 2021 · 5 comments
Labels
potential-new-behavior Discussions about RETURNN behaviour

Comments

@albertz
Copy link
Member

albertz commented May 21, 2021

#508

Thus effectively removing the default data key "data".

I don't have a strong opinion on this, so I just put this here and leave it open for discussion.

This is related but separate from #519 (default "from" layer arg).

@albertz albertz added the potential-new-behavior Discussions about RETURNN behaviour label May 21, 2021
@JackTemaki
Copy link
Collaborator

Strong agree, but I am also a person that started to use MetaDataset more often to simply be able to rename data as data key into someting more meaningful.

@albertz
Copy link
Member Author

albertz commented May 21, 2021

This would probably break most/all existing configs, so forcing users to change data to data:data (or however they data key is called). So this is one of such changes which requires slightly more effort for users to adopt. So some more people should probably be involved here to express their opinion. @rwth-i6/returnn

@patrick-wilken

This comment has been minimized.

@patrick-wilken

This comment has been minimized.

@albertz
Copy link
Member Author

albertz commented May 25, 2021

This here is a case where we do not necessarily need a new behavior_version and instead could just print a deprecation warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
potential-new-behavior Discussions about RETURNN behaviour
Projects
None yet
Development

No branches or pull requests

3 participants