Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nn.dot should have better signature #67

Closed
albertz opened this issue Nov 6, 2021 · 0 comments
Closed

nn.dot should have better signature #67

albertz opened this issue Nov 6, 2021 · 0 comments
Milestone
first-release

Comments

@albertz
Copy link
Member

albertz commented Nov 6, 2021 •
edited
Loading

Instead of sources: List[LayerRef], it should get src1 and src2 or a and b or so.

Also, when we have consistent dim tags, and unique dim tags (#17), we can simplify it. There only need to be a single red argument then.

We should maybe also implement the recently proposed simplifications for DotLayer (rwth-i6/returnn#739) and further adopt nn.dot here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
first-release
Development

No branches or pull requests
1 participant
@albertz