Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to fix blast deployment script configuration #368

Open
andreivladbrg opened this issue Jul 15, 2024 · 3 comments
Open

Try to fix blast deployment script configuration #368

andreivladbrg opened this issue Jul 15, 2024 · 3 comments
Labels
effort: low Easy or tiny task that takes less than a day. priority: 3 Nice-to-have. Willing to ship without this. type: refactor Change that neither fixes a bug nor adds a feature.

Comments

@andreivladbrg
Copy link
Member

The current blast deployment script configuration does not work as expected:

// Configure Blast mainnet yield and gas modes.
batchLockup.configureRebasingAsset({ asset: USDB, yieldMode: YIELD_MODE });
batchLockup.configureRebasingAsset({ asset: WETH, yieldMode: YIELD_MODE });
batchLockup.configureYieldAndGas({ blast: BLAST, yieldMode: YIELD_MODE, gasMode: GAS_MODE, governor: admin });
batchLockup.transferAdmin(admin);
merkleLockupFactory = new SablierV2MerkleLockupFactory{ salt: salt }(msg.sender);
// Configure Blast mainnet yield and gas modes.
merkleLockupFactory.configureRebasingAsset({ asset: USDB, yieldMode: YIELD_MODE });
merkleLockupFactory.configureRebasingAsset({ asset: WETH, yieldMode: YIELD_MODE });
merkleLockupFactory.configureYieldAndGas({
blast: BLAST,
yieldMode: YIELD_MODE,
gasMode: GAS_MODE,
governor: admin
});
merkleLockupFactory.transferAdmin(admin);

When you run, it reverts with CallerNotAdmin.

@andreivladbrg andreivladbrg added effort: low Easy or tiny task that takes less than a day. priority: 3 Nice-to-have. Willing to ship without this. type: refactor Change that neither fixes a bug nor adds a feature. labels Jul 15, 2024
@smol-ninja
Copy link
Member

How do you plan to fix it?

@andreivladbrg
Copy link
Member Author

not sure yet

@andreivladbrg andreivladbrg changed the title Fix blast deployment script configuration Try to fix blast deployment script configuration Jul 15, 2024
@smol-ninja
Copy link
Member

Leaving my comment for future reference:

A possible solution could be to dig in on why the foundry uses from address from the base script during deployment but fails to do so during the configuring txns hence the CallerNotAdmin error. See if there is a way to set the caller address in the Foundry script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: low Easy or tiny task that takes less than a day. priority: 3 Nice-to-have. Willing to ship without this. type: refactor Change that neither fixes a bug nor adds a feature.
Projects
None yet
Development

No branches or pull requests

2 participants