Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md #7

Open
SamGG opened this issue Apr 19, 2020 · 0 comments
Open

README.md #7

SamGG opened this issue Apr 19, 2020 · 0 comments

Comments

@SamGG
Copy link

SamGG commented Apr 19, 2020

Hi Sofie,

I think there is something missing in the sentence

normParams takes "nQ", the number of quantiles. Additionally, quantile_values The goal can be "mean", one of the batch labels, or nQ numbers (e.g. nQ = 2, )

Moreover, I think you should describe a basic workflow showing the use of nQ. I tried it and I think it could be more robust in some cases. In the following the setup tends to lead to a line (nQ=2) or relative straight line (nQ=5).

# A straight model is nQ = 2, quantileValues = c(0.001, 0.999)
# Model relying 5 quantiles (nQ = 5), which are described below
png("nQ_5.png",
    width = length(channels) * 300,
    height = (nrow(train_data) * 2 + 1) * 300)
model_nQ_5 <- QuantileNorm.train(
  files = train_data$Path,
  labels = train_data$Batch,
  channels = channels,
  transformList = transformList,
  nQ = 5,
  quantileValues = c(0.001, 0.01, 0.95, 0.98, 0.999),
  plot = TRUE)
dev.off()
# Check the result among the training data
QuantileNorm.normalize(
  model = model_nQ_5,
  files = train_data$Path,
  labels = train_data$Batch,
  transformList = transformList,
  transformList.reverse = transformList.reverse,
  outputDir = "nQ_5",
  prefix = "nQ_5_",
  verbose = TRUE)
# Apply to whole set
QuantileNorm.normalize(
  model = model_nQ_5,
  files = validation_data$Path,
  labels = validation_data$Batch,
  transformList = transformList,
  transformList.reverse = transformList.reverse,
  outputDir = "nQ_5",
  prefix = "nQ_5_",
  verbose = TRUE)

Best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant