Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time offset 1 hour out when accessing datetimes with datetime set in GMT when in BST #10560

Open
kale1d0code opened this issue Oct 22, 2024 · 0 comments
Labels
Area: Emails Issues & PRs related to all things regarding emails & email module Priority:Important Issues & PRs that are important; broken functions, errors - there are workarounds Severity: Moderate Key function failed, but no or little impact Type: Bug Bugs within the core SuiteCRM codebase Type:Suggestion Issue containing a suggestion of functionality, process or UI. Associated PRs are called enhancement

Comments

@kale1d0code
Copy link
Contributor

Issue

The CRM system uses UTC to store and process datetimes.
The system offsets any times it stores with an end-user timezone mostly for viewing purposes but this would happen anytime a datetime is accessed for any reason.

This causes problems when sending automated emails.
The system uses UTC when it sends emails outside of a user context which causes every single datetime used in an email template to be incorrect if the email wasn't sent due to an end-user action.

When a user views a GMT datetime when the actual date is BST, the viewed datetime would also be incorrect.

This issue affects all SuiteCRM versions I have used 7.10 -> 7.14

Possible Fix

implement a system timezone to offset datetimes during automation (outside user context)

do not mix BST and GMT

Steps to Reproduce the Issue

1. create a workflow or logic hook which extracts the time from a datetime to something like a text field for a record
2. set this datetime to a date in november on your record (GMT)
3. set your system time to a date or time within BST
4. trigger the workflow / logic hook
5. observe the incorrect time on the textfield
...

Context

sending out meeting notifications to delegates and the delegates showing up an hour early.

Version

7.14.2

What browser are you currently using?

Chrome

Browser Version

Google Chrome Version 129.0.6668.89 (Official Build) (64-bit)

Environment Information

MariaDB 10.9.4 | PHP 7.4.25

Operating System and Version

Debian GNU/Linux 10 (buster)

@kale1d0code kale1d0code added the Type: Bug Bugs within the core SuiteCRM codebase label Oct 22, 2024
@johnM2401 johnM2401 added Type:Suggestion Issue containing a suggestion of functionality, process or UI. Associated PRs are called enhancement Priority:Important Issues & PRs that are important; broken functions, errors - there are workarounds Area: Emails Issues & PRs related to all things regarding emails & email module Severity: Moderate Key function failed, but no or little impact labels Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Emails Issues & PRs related to all things regarding emails & email module Priority:Important Issues & PRs that are important; broken functions, errors - there are workarounds Severity: Moderate Key function failed, but no or little impact Type: Bug Bugs within the core SuiteCRM codebase Type:Suggestion Issue containing a suggestion of functionality, process or UI. Associated PRs are called enhancement
Projects
None yet
Development

No branches or pull requests

2 participants