Email signatures can remove an email thread when using reply to

[ojs87]

Issue

Email signatures will sometimes remove the email thread when replying to an email.

Email signatures elements that are on an email thread will also be replaced by the users email signature.

Email signatures will occasionally not be added to the email if the From fields have not been fully loaded in.

From fields can fail to load due to php82 fatal errors

PHP Fatal error:  Uncaught TypeError: EmailsDataAddressCollector::getFillDataAddressArray(): Argument #7 ($prependSignature) must be of type bool, null given, called in /var/www/SuiteCRM/modules/Emails/EmailsDataAddressCollector.php on line 673 and defined in /var/www/SuiteCRM/modules/Emails/EmailsDataAddressCollector.php:753

PHP Fatal error:  Uncaught TypeError: in_array(): Argument #2 ($haystack) must be of type array, bool given in /var/www/SuiteCRM/modules/Emails/EmailsDataAddressCollector.php:151

Possible Fix

Various fixes to EmailsComposeView.js, EmailsControllerActionGetFromFields.php, EmailsDataAddressCollector.php

Steps to Reproduce the Issue

1. Set up an email signature on the user profile
2. Import an email to reply to
3. Open the email and choose Reply To
4. See that occasionally the email thread will be deleted, the email signature will not be loaded, and previous email signature elements can be replaced by the users current email signature(even if other suiteCRM users are in the thread)
...

Context

Email is an integral part of the CRM system and these inconsistencies are causing issues.

Version

7.14.6

What browser are you currently using?

Firefox

Browser Version

FireFox v132.0

Environment Information

PHP8.2

Operating System and Version

Ubuntu 22.04.4 LTS