Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace allocated Vecs with MaybeUninit where possible #12

Open
nastevens opened this issue Mar 8, 2020 · 0 comments
Open

Replace allocated Vecs with MaybeUninit where possible #12

nastevens opened this issue Mar 8, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@nastevens
Copy link
Collaborator

Since there are a lot of buffers in this library, it would be an ideal candidate for using MaybeUninit and possibly the uninit crate. At the minimum the update_to_vec functions could be made more efficient by not requiring a zeroed Vec be created and then filled.

It may be a good idea to add some benchmarks before taking this on so that any gains can be quantified.
@nastevens nastevens added the enhancement New feature or request label Mar 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nastevens