Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] batch and subset should be moved into the standard cmd methods #67000

Open
whytewolf opened this issue Oct 25, 2024 · 0 comments
Labels
Feature new functionality including changes to functionality and code refactors, etc. needs-triage
Milestone

Comments

@whytewolf
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
current batch and subset have their own api interfaces. cmd_batch and cmd_subset. these 2 functionalities lack a method for async calling them. which leads to issues if you want to use these features with salt-api or other python methods.

this means to use batch or subset we cannot follow the recommended best practice
https://docs.saltproject.io/en/latest/ref/netapi/all/salt.netapi.rest_cherrypy.html#best-practices

Describe the solution you'd like
move batch and subset into cmd, and cmd_*, and depreciate cmd_batch and cmd_subset

Describe alternatives you've considered
an alternative was to add async methods for both batch and subset, but his seems least viable.

@whytewolf whytewolf added Feature new functionality including changes to functionality and code refactors, etc. needs-triage labels Oct 25, 2024
@dmurphy18 dmurphy18 added this to the Argon v3008.0 milestone Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature new functionality including changes to functionality and code refactors, etc. needs-triage
Projects
None yet
Development

No branches or pull requests

2 participants