Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow adding GenericFile to GenericWork in memory (without saving either object) #146

Open
flyingzumwalt opened this issue Jul 13, 2015 · 3 comments
Labels

Comments

@flyingzumwalt
Copy link
Member

This is the best example I could find with a quick search in sufia-core. There are definitely more in curation_concerns.

sufia-core catalog_controller.rb
Had to rewrite this, which never actually saves the GenericWork and GenericFile objects
https://github.com/projecthydra-labs/sufia-core/blob/migrate_to_curation_concerns/spec/controllers/catalog_controller_spec.rb#L114-L135
and replace it with this:
https://github.com/projecthydra-labs/sufia-core/blob/migrate_to_curation_concerns/spec/controllers/catalog_controller_spec.rb#L114-L135

@flyingzumwalt
Copy link
Member Author

@elrayle @jcoyne

@grosscol
Copy link
Member

Getting the associations without a call to save is the primary hurdle? Is the goal of this to speed up tests?

@tpendragon
Copy link
Contributor

I think it's more than just tests - you should be able to build things up in memory before persisting, and right now you can't. Seems related to samvera/active_fedora#858

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Backlog
Development

No branches or pull requests

5 participants