Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible wrapper bugs in __fenix_repair ranks #28

Open
rfvander opened this issue Mar 30, 2017 · 1 comment
Open

Possible wrapper bugs in __fenix_repair ranks #28

rfvander opened this issue Mar 30, 2017 · 1 comment
Labels

Comments

@rfvander
Copy link
Contributor

In the following code. I think we need to use PMPI, not MPI, in the calls between pairs of asterisks. If not for set_error_handler, then certainly for free, because this will be something we will need to intercept in the future.

while (!repair_success) { 
    repair_success = 1;
    ret = MPIF_Comm_shrink(*__fenix_g_world, &world_without_failures);
    /* if (ret != MPI_SUCCESS) { debug_print("MPI_Comm_shrink. repair_ranks\n"); } */
    if (ret != MPI_SUCCESS) { 
      repair_success = 0;
      goto END_LOOP; 
    } 
 
    ret = **MPI_Comm_set_errhandler**(world_without_failures, MPI_ERRORS_RETURN);
    if (ret != MPI_SUCCESS) { 
      repair_success = 0;
      **MPI_Comm_free**(&world_without_failures);
      goto END_LOOP; 
    }
@rfvander rfvander added the bug label Mar 30, 2017
@keitat
Copy link
Contributor

keitat commented Mar 31, 2017

I will apply a fix to issue_01 and master copy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants