-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing class call in example files #41
Comments
I think we had originally promoted the Scenario class to the top level and then decided not to do that but forgot to update the examples. We need to get the examples pynb tests going so we catch this. Thank you @b-lampe for finding and reporting it! You get the 🥇 issue claim! |
The regression.ipydb notebook also has errors, and I will fix it as well |
Fixes: Missing class call in example files #41 The ipython notebooks were not being tested. This led to an error in the example notebooks which are now fixed. The testing of any ipynb notebooks checked into the repo has also been added.
Tests are passing, waiting on review at which point will merge in. See https://github.com/sandialabs/sansmic/actions/runs/11152706061 |
* build: update and test example jupyter/ipython notebooks Resolves: Missing class call in example files #41 The ipython notebooks were not being tested. This led to an error in the example notebooks which are now fixed. The testing of any ipynb notebooks checked into the repo has also been added. * build: add nbstripout to pre-commit actions to clean notebooks files * build(examples): need matplotlib to test the example notebooks * test: add missing regression testing data file * build: requirements.txt matplotlib missing
Summary
The first line of Cell 17 (or line 55) of the example file "basic.ipynb" omits calling the "model" class. Should be modified to:
test2scen = sansmic.model.Scenario(
The same omission happens multiple times in the example file.
Thanks!
The text was updated successfully, but these errors were encountered: