Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing class call in example files #41

Closed
b-lampe opened this issue Oct 2, 2024 · 3 comments · Fixed by #42
Closed

Missing class call in example files #41

b-lampe opened this issue Oct 2, 2024 · 3 comments · Fixed by #42
Assignees
Labels
bug Something isn't working

Comments

@b-lampe
Copy link

b-lampe commented Oct 2, 2024

Summary
The first line of Cell 17 (or line 55) of the example file "basic.ipynb" omits calling the "model" class. Should be modified to:

test2scen = sansmic.model.Scenario(

The same omission happens multiple times in the example file.

Thanks!

Screenshot 2024-10-02 151903

@dbhart
Copy link
Collaborator

dbhart commented Oct 2, 2024

I think we had originally promoted the Scenario class to the top level and then decided not to do that but forgot to update the examples. We need to get the examples pynb tests going so we catch this.

Thank you @b-lampe for finding and reporting it! You get the 🥇 issue claim!

@dbhart dbhart self-assigned this Oct 2, 2024
@dbhart dbhart added the bug Something isn't working label Oct 2, 2024
@dbhart
Copy link
Collaborator

dbhart commented Oct 2, 2024

The regression.ipydb notebook also has errors, and I will fix it as well

dbhart added a commit that referenced this issue Oct 2, 2024
Fixes: Missing class call in example files #41

The ipython notebooks were not being tested. This led to an error in the example notebooks which are now fixed. The testing of any ipynb notebooks checked into the repo has also been added.
@dbhart dbhart linked a pull request Oct 2, 2024 that will close this issue
@dbhart dbhart mentioned this issue Oct 2, 2024
@dbhart
Copy link
Collaborator

dbhart commented Oct 2, 2024

Tests are passing, waiting on review at which point will merge in. See https://github.com/sandialabs/sansmic/actions/runs/11152706061
for output from the tests in the summary.

dbhart added a commit that referenced this issue Oct 3, 2024
* build: update and test example jupyter/ipython notebooks

Resolves: Missing class call in example files #41

The ipython notebooks were not being tested. This led to an error in the example notebooks which are now fixed. The testing of any ipynb notebooks checked into the repo has also been added.

* build: add nbstripout to pre-commit actions to clean notebooks files

* build(examples): need matplotlib to test the example notebooks

* test: add missing regression testing data file

* build: requirements.txt

matplotlib missing
@dbhart dbhart closed this as completed in #42 Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants