Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection issues with latest master when .nrepl-port is not present #47

Open
yayitswei opened this issue Nov 3, 2024 · 3 comments
Open

Comments

@yayitswei
Copy link

yayitswei commented Nov 3, 2024

Just a heads up for folks discovering the project - the latest master has connection issues when working with projects without an .nrepl-port file.

Environment:
GNU Emacs 29.4 on OSX

Details:

  • Error: "Wrong type argument: processp, nil" when trying to evaluate code
  • Root cause: monroe-connection returns nil because process name matching doesn't handle all cases
  • Debug shows two processes exist but aren't found:
    • "monroe" (status: run)
    • "monroe/localhost:7888" (status: open)
  • monroe-net-filter is attached to monroe/localhost:7888 but main REPL process uses default filter
  • monroe-session remains nil after connection

Workaround:
Using commit 508f5ed which is known-good for this use case.

To use the working version with straight.el:

(straight-use-package
 '(monroe :type git
          :host github
          :repo "sanel/monroe"
          :commit "508f5ed0f88b0b5e01a37d456186ea437f44d93c"))
@yayitswei
Copy link
Author

Also, I wanted to express my appreciation - I've been using Monroe for a decade now! Thanks @sanel for writing such a solid and reliable piece of software. It was and still is a core part of my workflow.

@sanel
Copy link
Owner

sanel commented Nov 3, 2024

Thank you @yayitswei! I was planing to revert latest merges because I feel they are bit unstable. By reverting to 508f5ed, have you noticed any other issues? How long have you running 508f5ed in your setup?

@yayitswei
Copy link
Author

I've been using 508f5ed for about a week with no issues. Before that, I was using a version from 2016.
To be fair, I'm sure most of the commits since then have been fine - I just haven't had time to bisect the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants