Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

purge_dups and hifiasm? #35

Open
nikostr opened this issue Mar 21, 2024 · 3 comments
Open

purge_dups and hifiasm? #35

nikostr opened this issue Mar 21, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@nikostr
Copy link

nikostr commented Mar 21, 2024

Description of the bug

Hifiasm has built-in purging of haplotigs and seem to claim that purge_dups is too aggressive in purging (chhylp123/hifiasm#162). Have you done comparisons of the purging done by hifiasm and purge_dups? Would it make sense to allow users to disable the purge_dups purging or allow users to set the hifiasm purging parameters?

Command used and terminal output

No response

Relevant files

No response

System information

No response

@nikostr nikostr added the bug Something isn't working label Mar 21, 2024
@ksenia-krasheninnikova
Copy link
Contributor

Hi @nikostr,

In the datasets with a fair level of heterozygosity hifiasm primary assembly contains a noticeable amount of the retained haplotype. In these cases purge_dups has been showing a stable performance with balancing pri and alt assemblies. However in the cases with low heterozygosity it can be possible that the hifiasm purging is sufficient or even no purging is required at all.
The workflow in the latest release is the basic implementation of Sanger Tree of Life assembly pipeline. We've been working on covering different use cases in the future releases.

@ksenia-krasheninnikova ksenia-krasheninnikova added enhancement New feature or request and removed bug Something isn't working labels Mar 22, 2024
@nikostr
Copy link
Author

nikostr commented Mar 22, 2024

Thank you! Is this true even for hifiasm's more aggressive purging settings? Or is the upside of purge_dups that it adapts how aggressive the purging is to the genome without needing to set this manually?

And that sounds super reasonable! Looking forward to seeing how this progresses! :)

@ksenia-krasheninnikova
Copy link
Contributor

hifiasm uses a graph based approach for purging, while purge dups does read mappings and one-to-one contigs alignment. For our assemblies we've got best results when they run in combination.
We have experienced that with hifiasm more aggressive purging settings there is a risk of over-purging.
These are our best practices so far. But it's fine to have a look at every case and adapt purging strategy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants