Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search highlighting #26

Open
Shatur opened this issue Apr 4, 2020 · 2 comments
Open

Search highlighting #26

Shatur opened this issue Apr 4, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@Shatur
Copy link
Collaborator

Shatur commented Apr 4, 2020

I noticed that plugin does not highlight searched items. Highlighting is also not works with such plugins as sandwich (It should show the word to which the modification will be applied.)

Is it possible to somehow access to neovim highlighting?

@sassanh
Copy link
Owner

sassanh commented Apr 5, 2020

Take a look at these:

:help ui-hlstate

https://github.com/neovim/neovim/pull/10504/files#diff-daa9e2681b8e40ea216038de23283f09R319

neovim/neovim#9421 (comment)

Then you need some trial and error.

In case you end up using searchpos I suggest injecting a piece of vimscript into neovim on initialization which defines a function that does this repetitive call of searchpos internally and returns the result, you may also want to limit it to 1000 results (so that in case there are 1,000,000 search results for example, the return value of the function isn't huge and also it doesn't take forever to respond) then you should be able to get all search highlight positions in a single msgpack function call.

There's also searchpairpos for highlighting pairs like if and fi or { and }.

But both of these just return the position the highlight starts and don't tell anything about where it ends which makes it hard for when user has search a regular expression. Also both of these change cursor position so you need to store it first. I think ui-hlstate is better because it doesn't have these restrictions and it works with all highlights and not just search and pair results, but it's a bit harder to implement.

@Shatur
Copy link
Collaborator Author

Shatur commented Apr 5, 2020

Will take a look, thank you!

@sassanh sassanh added the enhancement New feature or request label Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants