Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are there more prerequisites to the image? #20

Open
nils-a opened this issue May 2, 2021 · 9 comments
Open

Are there more prerequisites to the image? #20

nils-a opened this issue May 2, 2021 · 9 comments

Comments

@nils-a
Copy link

nils-a commented May 2, 2021

Given prerequisites are:

  • png
  • located in, or under, the .template.config

However, my image looks "inverted", somehow.

What it looks like:
image

What I would expect:
image

Information on the file I used:

Image:
  Filename: ..\..\nuspec\cake-medium.png
  Format: PNG (Portable Network Graphics)
  Mime type: image/png
  Class: DirectClass
  Geometry: 256x256+0+0
  Resolution: 28.33x28.33
  Print size: 9.03636x9.03636
  Units: PixelsPerCentimeter
  Colorspace: sRGB
  Type: TrueColorAlpha
  Base type: Undefined
  Endianness: Undefined
  Depth: 8-bit
  Channel depth:
    Red: 8-bit
    Green: 8-bit
    Blue: 8-bit
    Alpha: 8-bit
  Channel statistics:
    Pixels: 65536
    Red:
      min: 0  (0)
      max: 255 (1)
      mean: 88.1718 (0.345772)
      median: 0 (0)
      standard deviation: 85.5569 (0.335517)
      kurtosis: -0.723407
      skewness: 0.577586
      entropy: 0.358177
    Green:
      min: 0  (0)
      max: 255 (1)
      mean: 64.2388 (0.251917)
      median: 0 (0)
      standard deviation: 75.5915 (0.296437)
      kurtosis: 0.520318
      skewness: 1.20242
      entropy: 0.373593
    Blue:
      min: 0  (0)
      max: 255 (1)
      mean: 33.0931 (0.129777)
      median: 0 (0)
      standard deviation: 59.3856 (0.232885)
      kurtosis: 5.19374
      skewness: 2.21748
      entropy: 0.244348
    Alpha:
      min: 0  (0)
      max: 255 (1)
      mean: 155.58 (0.61012)
      median: 0 (0)
      standard deviation: 123.741 (0.48526)
      kurtosis: -1.78816
      skewness: -0.450789
      entropy: 0.147945
  Image statistics:
    Overall:
      min: 0  (0)
      max: 255 (1)
      mean: 85.271 (0.334396)
      median: 0 (0)
      standard deviation: 86.0688 (0.337525)
      kurtosis: -0.984744
      skewness: 0.767422
      entropy: 0.281016
  Alpha: none   #00000000
  Rendering intent: Perceptual
  Gamma: 0.45455
  Chromaticity:
    red primary: (0.64,0.33)
    green primary: (0.3,0.6)
    blue primary: (0.15,0.06)
    white point: (0.3127,0.329)
  Matte color: grey74
  Background color: white
  Border color: srgb(223,223,223)
  Transparent color: none
  Interlace: None
  Intensity: Undefined
  Compose: Over
  Page geometry: 256x256+0+0
  Dispose: Undefined
  Iterations: 0
  Compression: Zip
  Orientation: Undefined
  Properties:
    date:create: 2021-05-01T20:46:35+00:00
    date:modify: 2021-05-01T20:46:35+00:00
    png:gAMA: gamma=0.45455 (See Gamma, above)
    png:IHDR.bit-depth-orig: 8
    png:IHDR.bit_depth: 8
    png:IHDR.color-type-orig: 6
    png:IHDR.color_type: 6 (RGBA)
    png:IHDR.interlace_method: 0 (Not interlaced)
    png:IHDR.width,height: 256, 256
    png:pHYs: x_res=2833, y_res=2833, units=1
    png:sRGB: intent=0 (Perceptual Intent)
    png:text: 1 tEXt/zTXt/iTXt chunks were found
    signature: c0927c9e6b370ad79347d538a8bb688de0667ab9664d5a49d85e3b4229766635
    Software: paint.net 4.0
  Artifacts:
    verbose: true
  Tainted: False
  Filesize: 17063B
  Number pixels: 65536
  Pixels per second: 8.45233MP
  User time: 0.016u
  Elapsed time: 0:01.007
  Version: ImageMagick 7.0.10-58 Q16 x64 2021-01-16 https://imagemagick.org
@sayedihashimi
Copy link
Owner

@phenning any ideas?

@phenning
Copy link

phenning commented May 2, 2021

Not sure what would be causing that. Maybe compare them to the PNGs that are in the ASP NET core repo? We just load them, and pass them to the IDE as a base 64 encoded strings (this was due to Codespaces requirements.

@nils-a
Copy link
Author

nils-a commented May 3, 2021

Fun Fact: The image is fine - some of the colors are not. The images changes with the color scheme of VS:

Blue:
image

Light:
image

Dark:
image

It seems as if, when switching to dark mode, all colors of the image are replaced with colors whose value is set to 1 (in the HSV color model)

@sayedihashimi
Copy link
Owner

Hi @nils-a, my team isn't directly responsible for rendering the image. That is taken care of for us by the New Project Dialog. I think the best thing to do would be to Report a problem. It may be helpful to them to have your sample template so that they can try it out. They may have some guidance about how the icon can be updated to work better across the different VS themes.

@nils-a
Copy link
Author

nils-a commented May 3, 2021

I really haven't had much luck with that "Report a problem" feature. I'll give it another try.

@sayedihashimi
Copy link
Owner

If you share the URL of the issue, I can try to move it forward internally.

@nils-a
Copy link
Author

nils-a commented May 4, 2021

@nils-a
Copy link
Author

nils-a commented May 4, 2021

Interestingly enough: If I do not use a png and instead use the ico from the old vsix project the problem is gone and the image looks good. 🎉

@nils-a
Copy link
Author

nils-a commented Aug 2, 2021

@sayedihashimi I don't like to say "I told you so" but, as I said: That feedback forum has never been any help for me whatsoever.

https://developercommunity.visualstudio.com/t/images-added-to-net-clr-templates-are-rendered-dif/1412764?from=email&viewtype=all#T-ND1492187

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants