Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Squawk ignores excludes in the config file when excludes are passed on the cli #344

Open
Riscky opened this issue Mar 13, 2024 · 0 comments

Comments

@Riscky
Copy link

Riscky commented Mar 13, 2024

When using the --exclude command line flag, Squawk ignores excludes that were loaded from the config file.
To me this is unexpected (other linters that I've used combine those), and makes the config file less useful (to me).
Is there a use case for ignoring the excludes from the config file, or can we just combine the excludes?

This issue has been mentioned before in #213:

One case that I have not covered here is if the user wants to use both the CLI flags and the config file, one solution for this case would be to use the -c/--config flag together with the --exclude flag to signal the program that the user wants to merge those two together, but it's not a change that I want to do in this PR and it would be beneficial to reach an agreement with the contributors/community before deciding on a way to handle this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant