Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change master to a more positive name #35

Open
2 tasks
jonrkarr opened this issue Apr 20, 2021 · 2 comments
Open
2 tasks

Change master to a more positive name #35

jonrkarr opened this issue Apr 20, 2021 · 2 comments

Comments

@jonrkarr
Copy link
Contributor

jonrkarr commented Apr 20, 2021

Posting this here because I'm not aware of a more appropriate place. Feel free to transfer this elsewhere.

The issue

Because master has negative connotations, many people are replacing the term master with other terms such as main. Here's an article about GitHub's change from master to main.
https://www.theserverside.com/feature/Why-GitHub-renamed-its-master-branch-to-main

In addition, I think the meaning of the master could be clearer. For example, is this intended to indicate the SED-ML files that should be executed? Should files that have master=false not be executed? What should happen if no file has master=true? What is the only file that has master=true is not a SED-ML file (e.g., the only master file is a .cps file)?

Proposal

  • Rename the master attribute to something like main.
  • Clarify in the specifications how a positive value of this attribute should be interpreted.
@matthiaskoenig
Copy link
Contributor

Personally, I think there are more direct actions we can take to demonstrate that we are inclusive and politically correct. The main problem I see with the renaming is that it adds additional work in terms of

  • update attributes
  • update libraries
  • incompatibility of archives
  • breaking software
    and so on.

I would prefer more direct measures such as

  • adding a code of conduct to the COMBINE libraries
  • adding clear statements on inclusiveness, ... and so on
    which will not add additional work on the developers and users of COMBINE archives.

@jonrkarr
Copy link
Contributor Author

These should also be done, but they don't address the issue with the syntax itself.

libCOMBINE can maintain aliases to getMaster, setMaster, etc. to avoid developers needing to make changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants