Skip to content
This repository has been archived by the owner on Mar 2, 2022. It is now read-only.

Migrate client-side auth to msal.js v2 #120

Closed
scale-tone opened this issue Aug 19, 2021 · 1 comment
Closed

Migrate client-side auth to msal.js v2 #120

scale-tone opened this issue Aug 19, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@scale-tone
Copy link
Owner

scale-tone commented Aug 19, 2021

In other words, from implicit flow to auth code flow with PKCE.

Pull request for that is ready: #119
But sadly, this change would require reconfiguring existing AAD app registrations, until which a DfMon instance will get broken, once the new code gets deployed to it. Therefore let's postpone this migration.

To clarify: DfMon's client side supports both server-directed login flow and client-side auth (done with msal.js). This whole matter applies only to the latter case. While server-directed flow is sort of recommended, is used by default and won't get anyhow affected by whatever changes we make on the client side.

@scale-tone
Copy link
Owner Author

Closing in favor of microsoft/DurableFunctionsMonitor#4

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant