You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a suggestion to not throw an error when calling Identity.hasSession() in a browser without an active session (user is logged out). For example this makes it harder to distinguish real errors in the Identity.on('error', callback) function.
We've had some issues implementing the JS SDK, mostly coming down to unexpected behavior (like this or #72) or missing/confusing documentation (like the fact the redirect URLs in SelfService also double as a CORS domain whitelist). So this is just us trying to help you help us, so to speak 😄
We only use and see parts of your APIs so of course you'll know best what makes sense short-term vs long-term 👍
This is a suggestion to not throw an error when calling
Identity.hasSession()
in a browser without an active session (user is logged out). For example this makes it harder to distinguish real errors in theIdentity.on('error', callback)
function.Compare with for example the browser
fetch
API: https://developer.mozilla.org/en-US/docs/Web/API/Response, where only network errors are thrown as "real errors", and everything else is successful but together with a statusCode.Suggestion from SvD 😃
The text was updated successfully, but these errors were encountered: