Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(dependency) - upgraded JUnit and jackson #354

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

catull
Copy link

@catull catull commented May 27, 2024

Upgraded the dependencies in pom.xml and build.gradle.
Also followed the suggestion to re-write the deprecated task to task.register.

Closes #353

Upgraded the dependencies in `pom.xml` and `build.gradle`.
Also followed the suggestion to re-write the deprecated `task` to `task.register`.
@larsga
Copy link
Collaborator

larsga commented May 27, 2024

Thanks for taking care of this! I have dependabot configured, and it should have told us about this, but it looks like the alerting rules had been broken somehow. I've fixed that now, I hope.

The build fails in some cases, I see. I can look into that later.

@catull
Copy link
Author

catull commented May 28, 2024

Once dependabot works, you can reject this PR.

@catull
Copy link
Author

catull commented May 28, 2024

@larsga In build.gradle, the Java source and target are specified as

sourceCompatibility = 11
targetCompatibility = 11

Why does the build matrix include OracleJDK / OpenJDK 8, 9 and/or 10 ?
They all fail.

Should the above config be chanegd to = 8 for both source and target compatibility ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some dependencies are old
2 participants