Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failed to build test_coordgen on static mode #116

Open
jyhpsycho opened this issue Jul 25, 2022 · 1 comment · May be fixed by #117
Open

Failed to build test_coordgen on static mode #116

jyhpsycho opened this issue Jul 25, 2022 · 1 comment · May be fixed by #117

Comments

@jyhpsycho
Copy link

jyhpsycho commented Jul 25, 2022 •
edited
Loading

How to reproduce:

  1. Build static maeparser, and install on ../libmaeparser-1.2.4-220427
  2. Clone current repository.
  3. Create some build directory and chdir into it.
  4. Run following command to configure and build:
    cmake \ -DCMAKE_INSTALL_PREFIX=../coordgenlibs-3.0.0-220427 \ -DCOORDGEN_BUILD_SHARED_LIBS=OFF \ -Dmaeparser_DIR=../libmaeparser-1.2.4-220427 \ ../coordgenlibs
    cmake --build . --config Release -j

Expected behavior:

  • The build process should be complete without any errors.

Actual result:

How to fix:

  • Apply following patch. It appends missing Boost::iostreams and libz dependency on building test_coordgen. Thanks to github's file extension check.
    add-missing-deps.patch.txt
@d-b-w
Copy link
Collaborator

d-b-w commented Jul 25, 2022

@jyhpsycho -
Would you be able to submit a PR with that patch?

jyhpsycho added a commit to jyhpsycho/coordgenlibs that referenced this issue Jul 26, 2022
@jyhpsycho
Add missing dependencies for test_coordgen
0e8ec5d 
It will fix schrodinger#116
@jyhpsycho jyhpsycho linked a pull request Jul 26, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add missing dependencies for test_coordgen jyhpsycho/coordgenlibs
2 participants
@d-b-w @jyhpsycho