Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resizing columns with touch scrolls page vertically #508

Open
marhaupt opened this issue Jan 9, 2020 · 3 comments
Open

Resizing columns with touch scrolls page vertically #508

marhaupt opened this issue Jan 9, 2020 · 3 comments

Comments

@marhaupt
Copy link

marhaupt commented Jan 9, 2020

When resizing columns on touch device scrolls vertically whole page and throws error
[Intervention] Unable to preventDefault inside passive event listener due to target being treated as passive. See https://www.chromestatus.com/features/5093566007214080

Expected Behavior

The page doesn't move and only column resizes if you drag resize handle.

Steps to Reproduce

Can be reproduced even in desktop chrome in devtools using example by trying to resize collumns on responsive version of site.

Your Environment

Tested on Chrome 79 and above on Windows 10, probably happened before. Happens also on Android versions of Chrome and Firefox.

@pradeepnschrodinger
Copy link
Collaborator

pradeepnschrodinger commented Jan 20, 2020

The underyling issue is that of #407. We fixed it for table scrolling by manually adding "active" event listeners (see #422).
We'll likely need to do the same here for the touch handlers in FixedDataTableCell, or wait until React provides a way to specify the passiveness of the event listeners.

@wcjordan
Copy link
Member

@Nelsonio we're you able to investigate the fix suggested by @pradeepnschrodinger ? If so could you create a PR so we can get it back into the mainline? Thanks

@mirko77
Copy link

mirko77 commented Mar 12, 2020

I get the same error when scrolling horizontally on Chrome 80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants