Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception information is lost #372

Closed
cblp opened this issue Feb 9, 2024 · 7 comments
Closed

Exception information is lost #372

cblp opened this issue Feb 9, 2024 · 7 comments
Labels
Milestone

Comments

@cblp
Copy link
Contributor

cblp commented Feb 9, 2024

When any unknown exception happens, someExceptionHandler catches it and drops all information.

So I don't know how to put it in log to investigate. If it's possible please tell how.

Also, unhandledExceptionHandler has no sense because scottyExceptionHandler already caught all ScottyExceptions.

@cblp
Copy link
Contributor Author

cblp commented Feb 9, 2024

At least, print SomeException to stdout when verbose is on.

@ocramz
Copy link
Collaborator

ocramz commented Feb 9, 2024 via email

@ocramz
Copy link
Collaborator

ocramz commented Feb 10, 2024

@cblp I agree we could be logging and not dropping information in handlers (PRs welcome!)

I don't agree with the assessment re. unhandledExceptionHandler because there are effects outside ActionT as well.

@cblp
Copy link
Contributor Author

cblp commented Feb 10, 2024

@ocramz see #373. It's not exactly what I mean, but related. I don't know how to test existence/absence of putStr.

@ocramz
Copy link
Collaborator

ocramz commented Feb 10, 2024

@cblp good point about verbose too. Currently, verbose does nothing useful apart from toggling the initial banner and should definitely be improved.

@cblp
Copy link
Contributor Author

cblp commented Feb 11, 2024

@cblp good point about verbose too. Currently, verbose does nothing useful apart from toggling the initial banner and should definitely be improved.

See #374

@ocramz
Copy link
Collaborator

ocramz commented Mar 9, 2024

closed by #374

@ocramz ocramz closed this as completed Mar 9, 2024
@ocramz ocramz added this to the Release 0.22 milestone Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants