Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPIDERMON_MONITOR_SKIPPING_RULES only works with SpiderCloseMonitorSuite #456

Open
VMRuiz opened this issue Oct 1, 2024 · 0 comments
Open

Comments

@VMRuiz
Copy link
Collaborator

VMRuiz commented Oct 1, 2024

The SPIDERMON_MONITOR_SKIPPING_RULES setting is currently only used within SpiderCloseMonitorSuite, limiting its functionality to suites that extend from it:

if dict(crawler.settings).get("SPIDERMON_MONITOR_SKIPPING_RULES"):

This limitation is not mentioned in the documentation. It would be useful to extend this feature to all monitor suites.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant