Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should scratch-specific SVG import fixes be moved to SVG render? #18

Open
fsih opened this issue Sep 27, 2018 · 0 comments
Open

Should scratch-specific SVG import fixes be moved to SVG render? #18

fsih opened this issue Sep 27, 2018 · 0 comments

Comments

@fsih
Copy link

fsih commented Sep 27, 2018

SvgRender is the place to resolve Scratch 2.0-specific SVG rendering quirks, and fixes there will fix both scratch-render and scratch-paint. Fixes here https://github.com/LLK/paper.js/blob/f255218f36299dff5a7fe74af1ef6159c55b0ea4/src/svg/SvgImport.js#L304 risk different behavior between scratch paint and render. Is this the right place for them to be? (Some of these fixes deal with SVGs in general and not just Scratch 2.0 SVGs though)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants