Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When I draw a sprite, hold shift to draw a straight line but the stage does not have this straight line. #5414

Closed
qm88888888 opened this issue Feb 4, 2020 · 4 comments

Comments

@qm88888888
Copy link

Expected Behavior

stage have a straight line.

Actual Behavior

stage don't have a straight line.

Steps to Reproduce

hold shift and draw a straighe line.
image

Operating System and Browser

Win10 64 Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/79.0.3945.130 Safari/537.36

@towerofnix
Copy link
Contributor

towerofnix commented Feb 4, 2020

Can repro - it doesn't matter whether the line is drawn horizontally or vertically, nor the weight/diameter of the line. Drawing other shapes anywhere else in the shape makes the line appear.

I tried copying the line and pasting it, which placed it diagonally offset a few pixels (per normal copy behavior). This made the full costume appear on-stage. Then, I shifted it to be in the same cross-axis position (i.e. immediately behind the original line), and the costume promptly disappeared on-stage.

My guess is that some code is looking for the bounding area of the costume to be non-zero before rendering it, and it fails to consider the diameter of a line's stroke, treating it as a single 0-by-length shape.

@adroitwhiz
Copy link
Contributor

This is another instance of the bug fixed by scratchfoundation/scratch-svg-renderer#85.

I've also noticed a lot of Bugs and Glitches posts related to said bug, but haven't taken the time to compile them all yet.

@qm88888888
Copy link
Author

Can repro - it doesn't matter whether the line is drawn horizontally or vertically, nor the weight/diameter of the line. Drawing other shapes anywhere else in the shape makes the line appear.

I tried copying the line and pasting it, which placed it diagonally offset a few pixels (per normal copy behavior). This made the full costume appear on-stage. Then, I shifted it to be in the same cross-axis position (i.e. immediately behind the original line), and the costume promptly disappeared on-stage.

My guess is that some code is looking for the bounding area of the costume to be non-zero before rendering it, and it fails to consider the diameter of a line's stroke, treating it as a single 0-by-length shape.

thanks.

@qm88888888
Copy link
Author

This is another instance of the bug fixed by LLK/scratch-svg-renderer#85.

I've also noticed a lot of Bugs and Glitches posts related to said bug, but haven't taken the time to compile them all yet.

thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants