Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add highlight.js' 3rd-party languages #58

Open
24 tasks
allejo opened this issue Dec 22, 2019 · 5 comments
Open
24 tasks

Add highlight.js' 3rd-party languages #58

allejo opened this issue Dec 22, 2019 · 5 comments

Comments

@allejo
Copy link
Collaborator

allejo commented Dec 22, 2019

highlight.js has 3rd-party languages that come in the format of external repositories. There is no standard repository format for said languages at the moment, see highlightjs/highlight.js#2328.

Depending on how bored I get and how quickly they come up with a standard will determine when these languages will come to highlight.php

@joshgoebel
Copy link

Are you just planning to integrate them all as you have time?

@allejo
Copy link
Collaborator Author

allejo commented Feb 1, 2020

I was originally planning on doing this as time allowed but since I saw highlightjs/highlight.js#2328 being active, I may wait to see where that discussion goes to see I can automate them all in one go. Is that spec something you plan on implementing in v10 or sooner?

@joshgoebel
Copy link

joshgoebel commented Feb 1, 2020

It's already done (merging any day to master). If you were using the JS version and wanted to build a HUGE meta release library you'd just:

cd extra
# git clone 50 repos
cd ..
node ./tools/build.js
# the goodies are in the build folder, ready to rock

After I burn thru the PR backlog I've created the past few days I want to start shipping some alpha/betas. Publish date is still early March.

@allejo
Copy link
Collaborator Author

allejo commented Feb 1, 2020

You mean all of the 50 repos are structured or are supported by the highlight.js build system already? 😍 Or do you mean all of those repos are ready for v10, which will be published early March?

@joshgoebel
Copy link

joshgoebel commented Feb 2, 2020

All the repos should follow the spec. The new build system has all the magic.

highlightjs/highlight.js#2312

It should be merged in a few days but you can use it today if you switch to that branch. I presume the easiest thing for you is to use us to build the NPM assets then use that output to generate your static data. Likely whatever process you already use will “just work” without changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants