Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use attention set even for Approved commits #43

Open
studgeek opened this issue Dec 22, 2021 · 0 comments
Open

Only use attention set even for Approved commits #43

studgeek opened this issue Dec 22, 2021 · 0 comments

Comments

@studgeek
Copy link

Currently if "Only use Attention Set to judge required attention" is enabled, GerritMonitor still sends notifications for Approved commits.

I would expect those to be managed by attention set also. Gerrit will mark them as needing attention when they are approved. Using attention set allows the user to turn off attention in Gerrit if they want to wait to commit (for example if they are waiting on multiple approvals or something else to happen).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant