Error when a change doesn't have any revision

[avm99963]

My Gerrit server is answering API requests to /changes/ with some changes which have the revisions property empty:

)]}'
[
  [
    {
      // The |current_revision| property is missing.

      // And |revisions| contains an empty object:
      "revisions": {},

      // ...
    }
  ]
]

This is due to an incomplete/incorrect index, since I just restarted my Gerrit instance and I guess I did it at the worst time. Running gerrit index changes {ID} to reindex the changes affected by this fixed the issue.

When this error occurs, the popup doesn't show any CLs but instead shows the following error: TypeError: Cannot read properties of undefined (reading 'commit'). The error occurs here:

gerrit-monitor/src/gerrit.js

Lines 337 to 346 in 5d72c67

	// Returns the CL description.
	//
	// Requires detailed information (see fetchReviews).
	getDescription() {
	if (this.description_ === null) {
	this.description_ = new Description(
	this.getCurrentRevision().toJSON().commit.message);
	}
	return this.description_;
	}

Maybe we can consider returning null if there aren't any revisions? And then in the CL widget, we could show the subject as a fallback if the description is null.

[avm99963]

I mailed a PR with my suggestion in case we find it useful: #53

I tested the change by running http-server -p 8081 in the folder I attach compressed (which simulates a Gerrit server with this issue) and adding http://localhost:8081 to the extension options.

📎 gerrit-monitor-issue-53.tar.gz