You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We are currently using your library and setting the apiHost to our own proxy server to handle some updates on our end. In that proxy, we do some manipulation of the request body. Since GZip is enabled, this makes things a but more complicated on our end where we first have to decompress, then change data, and then compress again before sending the data onward. It would be nice if we could disable GZip compression in the Analytics configuration instead.
As a note, we currently use your swift, golang, and .NET libraries with the same proxy and have for a while. Those libraries don't enable GZip compression, this is only one we have seen that does this which we found odd.
Second note, if you are willing to allow for this, I would be more than happy to contribute the change to the repository following the guidelines you have set, just didn't want to waste my time if its not something the team is interested in.
The text was updated successfully, but these errors were encountered:
@kzettlmeier that's a good suggestion. in fact, enabling gzip should be the responsibility of RequestFactory. it is not doing this way now. we will add a fix to this
We are currently using your library and setting the
apiHost
to our own proxy server to handle some updates on our end. In that proxy, we do some manipulation of the request body. Since GZip is enabled, this makes things a but more complicated on our end where we first have to decompress, then change data, and then compress again before sending the data onward. It would be nice if we could disable GZip compression in theAnalytics
configuration instead.analytics-kotlin/core/src/main/java/com/segment/analytics/kotlin/core/HTTPClient.kt
Lines 90 to 94 in bfd0418
As a note, we currently use your swift, golang, and .NET libraries with the same proxy and have for a while. Those libraries don't enable GZip compression, this is only one we have seen that does this which we found odd.
Second note, if you are willing to allow for this, I would be more than happy to contribute the change to the repository following the guidelines you have set, just didn't want to waste my time if its not something the team is interested in.
The text was updated successfully, but these errors were encountered: