Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support datadog sets? #34

Open
yields opened this issue Jun 5, 2017 · 4 comments
Open

support datadog sets? #34

yields opened this issue Jun 5, 2017 · 4 comments

Comments

@yields
Copy link
Contributor

yields commented Jun 5, 2017

No description provided.

@yields
Copy link
Contributor Author

yields commented Jun 5, 2017

I'm not sure how to go about adding this, looks like engine.Set() is used for gauges :/

@achille-roussel
Copy link
Contributor

Maybe we can name it something different like UniqueSet and use another name for the main operation so it doesn't conflict.

@yields
Copy link
Contributor Author

yields commented Jun 5, 2017

so, something like this?

type Set struct {}
...

func (e *Engine) Unique(value string) { .. }

@achille-roussel
Copy link
Contributor

Well we can't call the top-level type Set because it conflicts with the top-level function. Maybe this:

type UniqueSet struct { ... }

then using one of these function names:

func Count(name string, tags ...Tag) { ... }
func Push(name string, tags ...Tag) { ... }
func Put(name string, tags ...Tag) { ... }
func Touch(name string, tags ...Tag) { ... }
func Track(name string, tags ...Tag) { ... }

The name Unique for the function name is not ideal because it's not a verb, so it doesn't communicate well what the action performed by the function is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants