Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(style): update outdated stylo project name and link #30960

Merged
merged 3 commits into from
Jan 3, 2024
Merged

docs(style): update outdated stylo project name and link #30960

merged 3 commits into from
Jan 3, 2024

Conversation

sculpt0r
Copy link
Contributor

Replace outdated project name and its link that leads to a webpage with inappropriate content.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #___ (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because docs

This PR is related but not entirely fix servo/book#32

@sculpt0r sculpt0r mentioned this pull request Dec 30, 2023
Open
@atouchet
Copy link
Contributor

I don't think that Stylo text needs to be changed (aside from the missing space). There's also a more specific Stylo page here https://wiki.mozilla.org/Quantum/Stylo but I don't know if that link is particularly useful as I don't know what was covered in the original page.

@sculpt0r
Copy link
Contributor Author

Well, even webarchive can't tell what was the original content...

In that case I'm not sure what would be the best solution? I would say that the current url should be changed or removed. Also, pointing to any related to the stylo page is better than pointing to some weird website.

@mrobinson
Copy link
Member

In that case I'm not sure what would be the best solution? I would say that the current url should be changed or removed. Also, pointing to any related to the stylo page is better than pointing to some weird website.

Let's just remove the link for now. We need to do a large documentation overhaul and not having the link for now is a good solution in the short-term.

@sculpt0r sculpt0r force-pushed the docs-style-cleanup branch from c5168ea to c808f9b Compare January 2, 2024 18:07
@sculpt0r sculpt0r force-pushed the docs-style-cleanup branch from c808f9b to 02c418d Compare January 2, 2024 18:07
@sculpt0r
Copy link
Contributor Author

sculpt0r commented Jan 2, 2024

@mrobinson - thanks for pointing to the right direction. I've updated the PR, so it could be check again :)

mrobinson
mrobinson approved these changes Jan 2, 2024
View reviewed changes
docs/components/style.md Outdated Show resolved Hide resolved
@mrobinson mrobinson enabled auto-merge January 2, 2024 23:18
@mrobinson mrobinson added this pull request to the merge queue Jan 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 3, 2024
@mrobinson mrobinson added this pull request to the merge queue Jan 3, 2024
Merged via the queue into servo:main with commit 94d76b2 Jan 3, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrobinson mrobinson mrobinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dead links in Architecture > Style
3 participants
@sculpt0r @atouchet @mrobinson