Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

requests 2.32.0+ does not work with truststore library #165

Open
timo-reymann opened this issue Dec 2, 2024 · 1 comment · May be fixed by #164
Open

requests 2.32.0+ does not work with truststore library #165

timo-reymann opened this issue Dec 2, 2024 · 1 comment · May be fixed by #164

Comments

@timo-reymann
Copy link

timo-reymann commented Dec 2, 2024 •
edited
Loading

Problem

Starting with the release 2.32.0 of the requests library the truststore library always leads to an recursion error. I was able to reproduce this on different Windows, Linux (Ubuntu) and macOS machines.

The crulpit seems to be the added "preloaded ssl context", which does not work well with truststore injection. While it seems to use urllib3 under the hood, the patched SSLContext is not really used.

Fix

Proposed fix is to import the requests.adapter package and patch the context accordingly with a truststore patched SSLContext, finished up in #164

Related
@timo-reymann timo-reymann linked a pull request Dec 2, 2024 that will close this issue
Open
@timo-reymann
Copy link
Author

@sethmlarson if you find some time I would appreciate if you could have a look 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Patch preloaded SSL context for requests library timo-reymann/fork-truststore
1 participant
@timo-reymann