Set-env command in GitHub actions is deprecated

[Mr0grog]

Several of our actions workflows use the set-env command to set environment variables for use in future steps of the workflow, but the set-env command is now deprecated and will be removed in the future. More info about the change (it’s a security issue): https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

We use it in several parts of all our workflows. Here’s one example:

stop-covid19-sfbayarea/.github/workflows/data_update.yml

Lines 55 to 56 in 1622c0e

	# Keep track of the version used so we can use it in commit messages
	echo "::set-env name=SCRAPER_COMMIT::$(git rev-parse HEAD)"

Instead of echo "::set-env name=<ENV_VAR_NAME>::<env_var_value>", we should now do echo "{name}={value}" >> $GITHUB_ENV. See the docs here: https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-commands-for-github-actions#environment-files

So, for example, this code:

# Keep track of the version used so we can use it in commit messages
echo "::set-env name=SCRAPER_COMMIT::$(git rev-parse HEAD)"

Should probably now be something along the lines of:

# Keep track of the version used so we can use it in commit messages
echo "SCRAPER_COMMIT='$(git rev-parse HEAD)'" >> $GITHUB_ENV

[kengoy]

I changed our all github action scripts not to use set-env but it still shows the warnings as well as add-path. Hmm...

[Mr0grog]

Ahhhh, they are coming from the peter-evans/create-pull-request action:

It looks like we are no longer on the latest version (we’re on v2, the latest is v3), so hopefully upgrading will fix it. Upgrade guide here, it looks like we shouldn’t have to change anything: https://github.com/peter-evans/create-pull-request/blob/master/docs/updating.md