Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for @pagefind/modular-ui #84

Open
davidandreoletti opened this issue Jun 16, 2024 · 6 comments
Open

Support for @pagefind/modular-ui #84

davidandreoletti opened this issue Jun 16, 2024 · 6 comments

Comments

@davidandreoletti
Copy link

davidandreoletti commented Jun 16, 2024

Hi,

Thanks for the integration. Would you consider adding support for @pagefind/modular-ui to support greater customisation, once it becomes production ready ?

@shishkin
Copy link
Owner

Hi @davidandreoletti. Thanks for raising this. I wasn't aware of the new Pagefind UI developments.

Modular approach does look interesting and more flexible but it also means larger component API surface. I would like to avoid having to mirror the pagefind components in Astro as much as possible as that would require too much maintenance to keep up with updates.

What use cases do you have in mind that you need modular UI for and how would you like them to look like in Astro?

@davidandreoletti
Copy link
Author

davidandreoletti commented Jun 17, 2024

Use case:

100% control on how pagefind behave for presenting the results without having to know / use pagefind css style.

Proposal:

  • The user passes in a "PagefindModularUI" instance to your astro component and the user is responsible for building search input + result HTML elements
  • the astro component automates index reading + pagefind.js lib loading as it is currently done.
  • astro + user must agree on a convention for some settings like "bundlePath", whether to load pagefind's modular ui css file, etc...

@shishkin
Copy link
Owner

Thanks for the suggestion @davidandreoletti. I'll try to take a stab at it when I have some time.

@davidandreoletti
Copy link
Author

No worries. it was already kind of you to create a nice astro integration for the non modal version.

@yujonglee
Copy link

@davidandreoletti

Just FYI:
Canary can be used to build SearchBar powered by Pagefind.

@davidandreoletti
Copy link
Author

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants