Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sideEffects settings break the cherry picking usage #1479

Closed
KonnorRogers opened this issue Aug 1, 2023 · 2 comments · Fixed by #1480
Closed

sideEffects settings break the cherry picking usage #1479

KonnorRogers opened this issue Aug 1, 2023 · 2 comments · Fixed by #1480

Comments

@KonnorRogers
Copy link
Collaborator

import '@shoelace-style/shoelace/dist/components/button/button.js';

Since the dist/components/button/button.js also imports dist/chunks/*.js which are not marked as sideEffects, which will be tree-shaked in production mode.

Originally posted by @weareoutman in #1450 (comment)

@Antony92
Copy link

Antony92 commented Aug 1, 2023

Can reproduce. New version 2.6.0 broke my production builds :/

I've added comments on something similiar here comment

@claviska
Copy link
Member

claviska commented Aug 1, 2023

@Antony92 sorry about that! This should be fixed with #1480. We'll kick off a patch release shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants