Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PulseSynchronizer is inconsistent and usage is not documented #7

Open
1 task done
dragonmux opened this issue Nov 10, 2024 · 0 comments
Open
1 task done

PulseSynchronizer is inconsistent and usage is not documented #7

dragonmux opened this issue Nov 10, 2024 · 0 comments
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request

Comments

@dragonmux
Copy link

Version

0.6.2

What happened?

In the CDC library, there are two major primitives for signal clock domain crossing - FFSynchronizer, and PulseSynchronizer.

FFSynchronizer is mostly well documented and its usage makes sense - signal in, signal out, domain on which the output signal is to be registered, and job's a good'n once handed to the module's submodules.

However, PulseSynchronizer has an entirely different API and no documentation on how it should be wired up and used. This API only concerns itself with the input and output domains, and then expects the user to m.d.comb the input and output signals to the .i and .o signals the block provides. This is harder to use and inconsistent, and should be fixed.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@dragonmux dragonmux added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request labels Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant