From 2285c2177068dfa51fa38087071f49f0ac553683 Mon Sep 17 00:00:00 2001
From: Sasha Weiss <sasha@signal.org>
Date: Tue, 13 Aug 2024 15:16:17 -0700
Subject: [PATCH] Isolate release-notes-related items into their own test case

---
 .../simple-chat-update-message.binproto       | Bin 480 -> 456 bytes
 .../simple-chat-update-message.jsonproto      |  56 +++++-------
 ...te-release-notes-donation-request.binproto | Bin 0 -> 144 bytes
 ...e-release-notes-donation-request.jsonproto |  80 ++++++++++++++++++
 4 files changed, 99 insertions(+), 37 deletions(-)
 create mode 100644 test-cases/simple-chat-update-release-notes-donation-request.binproto
 create mode 100644 test-cases/simple-chat-update-release-notes-donation-request.jsonproto

diff --git a/test-cases/simple-chat-update-message.binproto b/test-cases/simple-chat-update-message.binproto
index c8ee14d4d149034b948bea9dfe25f136510e5169..dc6f83a29032cf9d8f1df4c3aa0ed985210d7135 100644
GIT binary patch
delta 265
zcmZY1%ME}a5QJfYRe8&C&z594UTDFxD8o`TVb+9rn|%2*w`t~TmCBy2D#YrTPV)NQ
z01eOr24DmT@O><RS&9{~3Rr*zRCW+2i3j)&io*!R5fG$EBM@gml;Q_lFSJb$Z6Fyf

delta 289
zcmZY1yA6Oa5QAZIIYJ1plqX6?VjLP)U@XR96a?5sL}lsIFQ5MM$GJ<GHA>dJjL(=`
zt4)(cM-YGzJirqa@P4=~Rs#Zy0H_HKpxG%A5(zD!B_u%lz*$#<S`X-03?-<IfS$$t
IlL^Ui1Bk5}_5c6?

diff --git a/test-cases/simple-chat-update-message.jsonproto b/test-cases/simple-chat-update-message.jsonproto
index 798b600..6966039 100644
--- a/test-cases/simple-chat-update-message.jsonproto
+++ b/test-cases/simple-chat-update-message.jsonproto
@@ -1,4 +1,6 @@
-// Includes at least one message for each of the "simple chat updates".
+// Includes at least one message for each of the "simple chat updates",
+// excluding "release notes" messages that aren't supported on all platforms
+// yet.
 [
   {
     "backupTimeMs": "123456",
@@ -71,24 +73,17 @@
       }
     }
   },
-  // Release Notes channel
-  {
-    "chat": {
-      "id": "1",
-      "recipientId": "2"
-    }
-  },
   // 1:1 chat with Contact recipient 4
   {
     "chat": {
-      "id": "2",
+      "id": "1",
       "recipientId": "4"
     }
   },
   {
     "chatItem": {
       "authorId": "4",
-      "chatId": "2",
+      "chatId": "1",
       "dateSent": "1",
       "directionless": {},
       "updateMessage": {
@@ -101,7 +96,7 @@
   {
     "chatItem": {
       "authorId": "4",
-      "chatId": "2",
+      "chatId": "1",
       "dateSent": "2",
       "directionless": {},
       "updateMessage": {
@@ -114,7 +109,7 @@
   {
     "chatItem": {
       "authorId": "4",
-      "chatId": "2",
+      "chatId": "1",
       "dateSent": "3",
       "directionless": {},
       "updateMessage": {
@@ -127,7 +122,7 @@
   {
     "chatItem": {
       "authorId": "4",
-      "chatId": "2",
+      "chatId": "1",
       "dateSent": "4",
       "directionless": {},
       "updateMessage": {
@@ -137,23 +132,10 @@
       }
     }
   },
-  {
-    "chatItem": {
-      "authorId": "2",
-      "chatId": "1",
-      "dateSent": "5",
-      "directionless": {},
-      "updateMessage": {
-        "simpleUpdate": {
-          "type": "RELEASE_CHANNEL_DONATION_REQUEST"
-        }
-      }
-    }
-  },
   {
     "chatItem": {
       "authorId": "4",
-      "chatId": "2",
+      "chatId": "1",
       "dateSent": "6",
       "directionless": {},
       "updateMessage": {
@@ -166,7 +148,7 @@
   {
     "chatItem": {
       "authorId": "4",
-      "chatId": "2",
+      "chatId": "1",
       "dateSent": "7",
       "directionless": {},
       "updateMessage": {
@@ -179,7 +161,7 @@
   {
     "chatItem": {
       "authorId": "4",
-      "chatId": "2",
+      "chatId": "1",
       "dateSent": "8",
       "directionless": {},
       "updateMessage": {
@@ -192,7 +174,7 @@
   {
     "chatItem": {
       "authorId": "4",
-      "chatId": "2",
+      "chatId": "1",
       "dateSent": "9",
       "directionless": {},
       "updateMessage": {
@@ -205,7 +187,7 @@
   {
     "chatItem": {
       "authorId": "4",
-      "chatId": "2",
+      "chatId": "1",
       "dateSent": "10",
       "directionless": {},
       "updateMessage": {
@@ -218,7 +200,7 @@
   {
     "chatItem": {
       "authorId": "1",
-      "chatId": "2",
+      "chatId": "1",
       "dateSent": "11",
       "directionless": {},
       "updateMessage": {
@@ -231,7 +213,7 @@
   {
     "chatItem": {
       "authorId": "4",
-      "chatId": "2",
+      "chatId": "1",
       "dateSent": "12",
       "directionless": {},
       "updateMessage": {
@@ -244,7 +226,7 @@
   {
     "chatItem": {
       "authorId": "1",
-      "chatId": "2",
+      "chatId": "1",
       "dateSent": "13",
       "directionless": {},
       "updateMessage": {
@@ -257,7 +239,7 @@
   {
     "chatItem": {
       "authorId": "4",
-      "chatId": "2",
+      "chatId": "1",
       "dateSent": "14",
       "directionless": {},
       "updateMessage": {
@@ -270,7 +252,7 @@
   {
     "chatItem": {
       "authorId": "1",
-      "chatId": "2",
+      "chatId": "1",
       "dateSent": "14",
       "directionless": {},
       "updateMessage": {
@@ -283,7 +265,7 @@
   {
     "chatItem": {
       "authorId": "1",
-      "chatId": "2",
+      "chatId": "1",
       "dateSent": "15",
       "directionless": {},
       "updateMessage": {
diff --git a/test-cases/simple-chat-update-release-notes-donation-request.binproto b/test-cases/simple-chat-update-release-notes-donation-request.binproto
new file mode 100644
index 0000000000000000000000000000000000000000..e9b0cdff45f63b7fa4aa5a81e101b29065c0c931
GIT binary patch
literal 144
zcmZSMU=%oTgx!+MoJ%2*Y2xa)hn+k<<}RLPcyj64nP)HMe{DB<l<_$H9Yg8O8%iur
z`ALadEN-bKC0^_Tj0FrGj7)4oEF6ql3?Pchh(SY0je}W9iA#V14M_2Earjm$1efF&
eRSGalFtbSkwFxi@DDi<P3DzKnDi$s#4mJQ3D<9eb

literal 0
HcmV?d00001

diff --git a/test-cases/simple-chat-update-release-notes-donation-request.jsonproto b/test-cases/simple-chat-update-release-notes-donation-request.jsonproto
new file mode 100644
index 0000000..52fb1fb
--- /dev/null
+++ b/test-cases/simple-chat-update-release-notes-donation-request.jsonproto
@@ -0,0 +1,80 @@
+// Includes "release notes" simple chat updates.
+[
+  {
+    "backupTimeMs": "123456",
+    "version": "1"
+  },
+  {
+    "account": {
+      "profileKey": "YQKRq+3DQklInaOaMcmlzZnN0m/1hzLiaONX7gB12dg=",
+      "givenName": "Boba",
+      "familyName": "Fett",
+      "avatarUrlPath": "",
+      "accountSettings": {
+        "readReceipts": false,
+        "sealedSenderIndicators": true,
+        "typingIndicators": false,
+        "linkPreviews": false,
+        "notDiscoverableByPhoneNumber": false,
+        "preferContactAvatars": false,
+        "universalExpireTimerSeconds": 0,
+        "preferredReactionEmoji": [],
+        "displayBadgesOnProfile": false,
+        "keepMutedChatsArchived": false,
+        "hasSetMyStoriesPrivacy": false,
+        "hasViewedOnboardingStory": false,
+        "storiesDisabled": false,
+        "storyViewReceiptsEnabled": false,
+        "hasSeenGroupStoryEducationSheet": false,
+        "hasCompletedUsernameOnboarding": false,
+        "phoneNumberSharingMode": "NOBODY"
+      }
+    }
+  },
+  {
+    "recipient": {
+      "id": "1",
+      "self": {}
+    }
+  },
+  {
+    "recipient": {
+      "id": "2",
+      "releaseNotes": {}
+    }
+  },
+  {
+    "recipient": {
+      "id": "3",
+      "distributionList": {
+        "distributionId": "AAAAAAAAAAAAAAAAAAAAAA==",
+        "distributionList": {
+          "allowReplies": true,
+          "memberRecipientIds": [],
+          "name": "My Story",
+          "privacyMode": "ALL"
+        }
+      }
+    }
+  },
+  // Release Notes channel
+  {
+    "chat": {
+      "id": "1",
+      "recipientId": "2"
+    }
+  },
+  {
+    "chatItem": {
+      "authorId": "2",
+      "chatId": "1",
+      "dateSent": "5",
+      "directionless": {},
+      "updateMessage": {
+        "simpleUpdate": {
+          "type": "RELEASE_CHANNEL_DONATION_REQUEST"
+        }
+      }
+    }
+  },
+]