fix: correct datadir disk usage reporting in lighthouse.rs #6741
+23
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix disk usage metrics to show datadir usage instead of root
|
This should not require the addition of a new environment variable. Lighthouse already knows the data directory from the |
michaelsproul
added
the
waiting-on-author
|
@michaelsproul this one seems to be better |
|
That doesn't work @crStiv. Are you writing this PR with AI? |
Made an update, this one should be alright. I used chatgpt to help me create a pull request description |
michaelsproul
requested changes
Dec 28, 2024
common/eth2/src/lighthouse.rs
Outdated
| /// Gets the datadir which should be used. | ||
| fn get_data_dir() -> PathBuf { | ||
| // Try to get datadir from command line arguments | ||
| let args: Vec<String> = std::env::args().collect(); |
There was a problem hiding this comment.
We shouldn't be re-parsing the CLI args like this. They are already parsed by clap and available in the config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix datadir disk usage reporting in lighthouse.rs
Description
This pull request updates
lighthouse.rsto fix the disk usage metrics. Previously, the disk usage was calculated for the root directory (/). The new implementation correctly retrieves and uses theLIGHTHOUSE_DATADIRenvironment variable to calculate disk usage for the appropriate data directory. If the environment variable is not set, it defaults to/.Fixes #6687
Proposed Changes
disk_usagecalculation to use theLIGHTHOUSE_DATADIRenvironment variable.LIGHTHOUSE_DATADIRis not specified.Additional Info
LIGHTHOUSE_DATADIRenvironment variable. Reviewers should ensure the variable is correctly set in environments where this change is deployed.LIGHTHOUSE_DATADIRis missing or set to invalid paths.Allow edits by maintainers
Yes.
Please ensure contributions adhere to the repository's contributing guidelines and security policy.