Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken link on root-signing landing page #1396

Open
woodruffw opened this issue Oct 31, 2024 · 1 comment
Open

Broken link on root-signing landing page #1396

woodruffw opened this issue Oct 31, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@woodruffw
Copy link
Member

Apologies is this is the wrong repo! Let me know and I'd be happy to re-file or move.

The Sigstore TUF-on-CI instances have pages like this https://tuf-repo-cdn.sigstore.dev/

On that page is an "improve this page" link:

Screenshot 2024-10-31 at 12 12 10 PM

However, that link (https://github.com/sigstore/root-signing/edit/main/index.md) is broken, and I'm not sure where it's supposed to point to 🙂

h/t @miketheman for noticing this.

@woodruffw woodruffw added the bug Something isn't working label Oct 31, 2024
@jku
Copy link
Member

jku commented Oct 31, 2024

Yeah it's unfortunate. This is basically a tuf-on-ci bug:

  • tuf-on-ci produces a status page (currently in markdown) when the repository is published
  • the publish process uses jekyll-build-pages action to turn that into html: this includes adding things like the footer mentioned

this process was the path of least resistance, easiest to implement ... but turned out to be sub-optimal as the jekyll action is very rigid, and only really works on GitHub Pages with a very specific setup

This is pretty much the upstream bug: theupdateframework/tuf-on-ci#430 (it describes another issue but root cause is that jekyll and the action are unsuitable for the task).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants