Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle JPEG Borders #662

Open
gmjgeek opened this issue Aug 12, 2024 · 0 comments
Open

Handle JPEG Borders #662

gmjgeek opened this issue Aug 12, 2024 · 0 comments

Comments

@gmjgeek
Copy link
Contributor

gmjgeek commented Aug 12, 2024

Scripture App Builder supports PNG and JPEG borders, but the PWA only supports PNG. It expects the border to always be named borders/border.png and throws a 404 error if this file is not found.

If it is impractical to support JPEG borders in the PWA, we should consider warning the user before building a PWA with a JPEG border.

image

PWA error:

image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gmjgeek