Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipelines UI is confusing, especially the final "Rollback" step #104

Open
ss23 opened this issue Nov 20, 2014 · 4 comments
Open

Pipelines UI is confusing, especially the final "Rollback" step #104

ss23 opened this issue Nov 20, 2014 · 4 comments

Comments

@ss23
Copy link
Contributor

ss23 commented Nov 20, 2014

The rollback step button is green, implying you should click it to begin the next step. That's silly, you shouldn't.
It should be more clear that this is a "Revert, cancel, it all went wrong!" button.

It should also be clear that at this point, the deployment is considered complete and working.

@chillu
Copy link
Member

chillu commented Dec 11, 2014

+1111

@tractorcow
Copy link

Do you think the running description, colours, and/or option titles could be updated to better reflect their nature? https://github.com/silverstripe/deploynaut/blob/master/code/model/steps/EmergencyRollbackStep.php#L139

@chillu
Copy link
Member

chillu commented Dec 11, 2014

Don't have the UI in front of me at the moment, but I think the following changes could be clarifying its intent:

  • Style the button red
  • Style as a separate section rather than another pipeline step
  • Add a title "Emergency rollback"
  • Add a description like "Did something go wrong? For the next <x> minutes, you have the option to revert this release, and go back to <short commit message> (<sha>).". Count down the minutes the rollback is available. Or show the time when it will become unavailable.
  • Not sure if that's the case, but add something about database and asset state. E.g. "The revert will not affect the database or assets".
  • Add in smaller text below the button: "Protip: You can always revert to an earlier release later by performing a new release on an earlier commit".

@tractorcow
Copy link

Most of those should be pretty easy to do, other than the "separate section" task. What would be great is a rethink of the pipeline UI as a whole to better support descriptions on each available actions (rather than just using tooltips)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants