-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AddressSanitizer identifies buffer underflow in scan_aes.cpp create_aes128_schedule() #413
Comments
I get the same, not sure what it is yet. |
Thanks for the report. Can you tell me what platform you are using? |
I’m macOS Catalina, 10.15.7, Intel, Apple clang 12.0.0. I believe Julia has an Intel Mac, too. Let me check on my M1… |
So it may be the new compiler? |
Happy to report that I have replicated this on my M1 mac.
I should have this fixed by Sunday PM. |
Repro’d on my M1, too. Do you mind giving us a week? This looks fun to debug. :-D |
|
I was really planning on working out tonight. If you want, you can have until 8am tomorrow. |
Okay, I found the bug. Let me know if/when you want me to push. |
Nuts!On Apr 28, 2023, at 9:26 PM, Simson L. Garfinkel ***@***.***> wrote:
Okay, I found the bug. Let me know if/when you want me to push.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: ***@***.***>
|
I take it that's a yes/no/maybe? |
Yup, that looks like the right fix. I was looking forward to accepting the challenge, right after I finished watching TV, and you just went ahead and fixed it... Nuts! |
If you are looking for something fun, please try one of these:
Say the word and I will happily assign them to you. |
We're working on scan_lightgrep and stumbled across this AES issue in so doing. |
Contents of
src/test-suite.log
:Output of
git show
:Output of
./bootstrap.sh && LDFLAGS="-fsanitize=address -fno-omit-frame-pointer" CXXFLAGS="-fsanitize=address -fno-omit-frame-pointer -g -Og" ./configure
:Output of
make -j8 check
:The text was updated successfully, but these errors were encountered: