Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unrecognised keys should throw errors/warnings #139

Open
samvanstroud opened this issue Jul 23, 2024 · 3 comments
Open

Unrecognised keys should throw errors/warnings #139

samvanstroud opened this issue Jul 23, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@samvanstroud
Copy link

Currently, if a user adds an incorrect key, it is ignored. This can be confusing if a user misspells a valid key, or perhaps imagines a field is supported when it isn't.

If a user provides an invalid key, a warning or error should be raised

@samvanstroud samvanstroud added the enhancement New feature or request label Jul 23, 2024
@samvanstroud samvanstroud changed the title Unrecognised keys should throw errors Unrecognised keys should throw errors/warnings Jul 23, 2024
@sinaatalay
Copy link
Owner

This feature has been added in v1.12. Previously, the use of arbitrary keys resulted in errors. It allows users to use their own keys in their custom templates, as described here. However, I am open to discussing whether this feature is a good idea or not.

@samvanstroud
Copy link
Author

samvanstroud commented Jul 23, 2024

I would consider adding a allow_custom_keys option to configure this behaviour, it might save some confusion :)

@sinaatalay
Copy link
Owner

That sounds like a good idea. Maybe we need rendercv_settings in addition to cv, design, and locale_catalog. I will keep this issue open until we decide on an approach. Perhaps someone else could offer a new perspective as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants