Some Clicks are not being synced due to timezone mismatch

[jgdwyer]

When using this Tap, I noticed that the daily clicks total were lower than the totals reported in the Impact web app. Further investigation revealed that I was not receiving any clicks that were happening towards the end of the day local time. This appears to be due to a mismatch between the bookmarking datetime value for the Clicks object (UTC datetime) and the expected argument to the Clicks endpoint in the API (date in timezone that the company timezone is set in).

Example:

• Company timezone set to (GMT -04:00) Eastern Time (US & Canada) in Impact
• Tap is run every 6 hours at 0Z, 6Z, 12Z, & 18Z
• During the 0Z run, the previous bookmark value is loaded as 2021-08-22T18:00:00Z. Since the current UTC time is 2021-08-23T00:00:00Z the Clicks endpoint will be called twice, once with date=2021-08-22 and once with date=2021-08-23. Because the endpoint interprets the dates in ET, only data before 2021-08-22 8pm ET will be returned.
• At the end of the 0Z run, the bookmark value for Clicks is stored as 2021-08-23T00:00:00Z
• During the 6Z run the bookmark value is loaded and sent to the Clicks endpoint as 2021-08-23. This will return any clicks that have so far occurred on 2021-08-23 ET. But it will exclude all clicks on 2021-08-22 after 8pm ET.

I've confirmed this behavior in the raw extraction logs.