In chromedriver, in index.js script, function binPath with error in return, please fix it

[DadayanSamvel]

Have you read the documentation?

• Yes, I've read the how to make a reproducable bug guide
• Yes, I've read the how to debug my script guide

URL

I use local url, sorry can not repro

What are you trying to accomplish

in your code, binPath function never return driverPath for win32, linux and arm os:

binPath: function() {
let driverPath = path.resolve(__dirname, 'vendor', 'chromedriver');
if (os.platform() === 'win32') {
driverPath = driverPath + '.exe';
} else if (
(os.platform() === 'linux' && os.arch() === 'arm') ||
os.arch() === 'arm64'
) {
// Special handling for making it easy on Raspberry Pis
try {
const potentialChromdriverPath = execSync('which chromedriver');
if (potentialChromdriverPath !== undefined) {
return potentialChromdriverPath.toString().trim();
}
} catch (e) {
// Just swallow
}
} else {
return driverPath;
}
}

please fix to:

binPath: function() {
let driverPath = path.resolve(__dirname, 'vendor', 'chromedriver');
if (os.platform() === 'win32') {
driverPath = driverPath + '.exe';
} else if (
(os.platform() === 'linux' && os.arch() === 'arm') ||
os.arch() === 'arm64'
) {
// Special handling for making it easy on Raspberry Pis
try {
const potentialChromdriverPath = execSync('which chromedriver');
if (potentialChromdriverPath !== undefined) {
return potentialChromdriverPath.toString().trim();
}
} catch (e) {
// Just swallow
}
}
return driverPath;
}

What browser did you use?

Chrome

How to reproduce

any iteration

Relevant log output

No response

[soulgalore]

Hi @DadayanSamvel the reason is that the Chromedriver team do not provide a binary for those OS. You can ask https://bugs.chromium.org/p/chromedriver/issues/list them to add it. What OS are you using? On ARM there's a hack to use what the package finds using which, so you can install it with apt-get or what you are using.

[DadayanSamvel]

Thank for answer, i use linux сб, 12 февр. 2022 г., 15:52 Peter Hedenskog ***@***.***>:

…

Hi @DadayanSamvel <https://github.com/DadayanSamvel> the reason is that the Chromedriver team do not provide a binary for those OS. You can ask https://bugs.chromium.org/p/chromedriver/issues/list them to add it. What OS are you using? On ARM there's a hack to use what the package finds using which, so you can install it with apt-get or what you are using. — Reply to this email directly, view it on GitHub <#8 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AE5JQB3W3JMTBHUTUMMJUJ3U2ZQZJANCNFSM5OG4DGDA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.Message ID: ***@***.***>