Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updateStatus is a confusing name #26

Open
akuanti opened this issue Mar 7, 2018 · 0 comments
Open

updateStatus is a confusing name #26

akuanti opened this issue Mar 7, 2018 · 0 comments

Comments

@akuanti
Copy link
Collaborator

akuanti commented Mar 7, 2018

I find it unclear from the name what updateStatus() is supposed to do, which makes it difficult to remember when it is necessary to call it.

From the code, it looks like it can either

  1. Whitelist an application that has passed the application period without a challenge
  2. If there is a challenge that has finished its voting period (whether it's a new application or an existing listing), remove, add, or reject the applicant/listing

Is there some name that covers both aspects? Otherwise, it might make sense to split updateStatus() into two separate functions. Something like finalizeApplication() and finalizeChallenge()?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant