Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podcast:value is allowed in multiple channel elements #1

Closed
jamescridland opened this issue Jan 14, 2023 · 1 comment
Closed

podcast:value is allowed in multiple channel elements #1

jamescridland opened this issue Jan 14, 2023 · 1 comment

Comments

@jamescridland
Copy link

If you try to validate this feed then the validator kicks an error:

Multiple channel <podcast:value> elements are not allowed[[podcastindex]](https://github.com/Podcastindex-org/podcast-namespace/blob/main/docs/1.0.md#value)

The podcast:value tag is now allowed multiple times, to allow for access to multiple payment methods.

I've submitted a pull request to the documentation on Podcast Index, at Podcastindex-org/podcast-namespace#431

The line at

const value = ElementValidation.forSingleChild(level, node, callbacks, podcastIndexReference('https://github.com/Podcastindex-org/podcast-namespace/blob/main/docs/1.0.md#value'), ...Qnames.PodcastIndex.value).checkRequiredAttribute('type', isPodcastValueTypeSlug).checkRequiredAttribute('method', isNotEmpty).checkOptionalAttribute('suggested', isDecimal).checkRemainingAttributes().node;
is the one that checks for single elements, and should probably be deleted.

@johnspurlock-skymethod
Copy link
Contributor

This was implemented back in 132f302 once it was added to the namespace!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants